RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:07:46 +00:00
Code Issues Activity Actions

LibGUI: Remember the maximized value if a window hasn't been created yet

Browse source 
d0fb511d75 set the maximized window value
in the File Manager before a window was created, which resulted in crash
everytime you tried to open the program that was closed while it was
maximized. ugh

Here we do more-or-less what GUI::Window::set_rect() does, except we
don't add it to the WindowServer::create_window() IPC call.
That's because the Window Server knows nothing about menus at this
point and just assumes they don't need to be visible.
So if we try to maximize the window then, it could be slightly taller
and a titlebar could be hidden.

So even though it looks how it looks like, it does work and it doesn't
show in the startup size, as described in the mentioned commit (the call
is put a few lines before the initial update()). :^)
This commit is contained in:
Karol Kosek 2021-09-18 22:02:05 +02:00 • committed by Andreas Kling
parent 9705580c53
commit d91f194ddd
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGUI/Window.cpp
View file

@ -167,6 +167,7 @@ void Window::show()
return IterationDecision::Continue;
});
set_maximized(m_maximized_when_windowless);
reified_windows->set(m_window_id, this);
Application::the()->did_create_window({});
update();
@ -998,14 +999,17 @@ void Window::set_forced_shadow(bool shadow)
bool Window::is_maximized() const
{
if (!is_visible())
return false;
return m_maximized_when_windowless;
return WindowServerConnection::the().is_maximized(m_window_id);
}
void Window::set_maximized(bool maximized)
{
VERIFY(m_window_id != 0);
m_maximized_when_windowless = maximized;
if (!is_visible())
return;
WindowServerConnection::the().async_set_maximized(m_window_id, maximized);
}