RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:27:43 +00:00
Code Issues Activity Actions

Kernel: Use copy_n_from_user in sys$setgroups to check for overflow

Browse source
This commit is contained in:
Brian Gianforcaro 2021-02-21 08:05:09 -08:00 • committed by Andreas Kling
parent 4743afeaf4
commit d934e77522
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Syscalls/setuid.cpp
View file

@ -150,7 +150,7 @@ int Process::sys$setgroups(ssize_t count, Userspace<const gid_t*> user_gids)
Vector<gid_t> gids; Vector<gid_t> gids;
gids.resize(count); gids.resize(count);
if (!copy_from_user(gids.data(), user_gids.unsafe_userspace_ptr(), sizeof(gid_t) * count)) if (!copy_n_from_user(gids.data(), user_gids, count))
return -EFAULT; return -EFAULT;
HashTable<gid_t> unique_extra_gids; HashTable<gid_t> unique_extra_gids;