RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:37:42 +00:00
Code Issues Activity Actions

LibGUI+Applications: Rename automatic scrolling timer functions

Browse source 
Renames on_automatic_scrolling_timer_fired() =>
	automatic_scrolling_timer_did_fire()

The 'on_' prefix is usually reserved for AK::Function hooks.

Renames set_automatic_scrolling_{active,timer}() =>
	set_automatic_scrolling_timer_active()

For consistency, accuracy, and header file A E S T H E T I C S
This commit is contained in:
thankyouverycool 2022-12-25 15:41:33 -05:00 • committed by Andreas Kling
parent 5b02e6a46b
commit d938b9effe
10 changed files with 30 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/AbstractScrollableWidget.cpp
View file

@ -36,7 +36,7 @@ AbstractScrollableWidget::AbstractScrollableWidget()
m_automatic_scrolling_timer = add<Core::Timer>();
m_automatic_scrolling_timer->set_interval(50);
m_automatic_scrolling_timer->on_timeout = [this] {
on_automatic_scrolling_timer_fired();
automatic_scrolling_timer_did_fire();
};
}
@ -303,7 +303,7 @@ void AbstractScrollableWidget::scroll_to_bottom()
scroll_into_view({ 0, content_height(), 0, 0 }, Orientation::Vertical);
}
void AbstractScrollableWidget::set_automatic_scrolling_timer(bool active)
void AbstractScrollableWidget::set_automatic_scrolling_timer_active(bool active)
{
if (active == m_active_scrolling_enabled)
return;
@ -311,7 +311,7 @@ void AbstractScrollableWidget::set_automatic_scrolling_timer(bool active)
m_active_scrolling_enabled = active;
if (active) {
on_automatic_scrolling_timer_fired();
automatic_scrolling_timer_did_fire();
m_automatic_scrolling_timer->start();
} else {
m_automatic_scrolling_timer->stop();