RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 07:57:49 +00:00
Code Issues Activity Actions

LibGUI+Applications: Rename automatic scrolling timer functions

Browse source 
Renames on_automatic_scrolling_timer_fired() =>
	automatic_scrolling_timer_did_fire()

The 'on_' prefix is usually reserved for AK::Function hooks.

Renames set_automatic_scrolling_{active,timer}() =>
	set_automatic_scrolling_timer_active()

For consistency, accuracy, and header file A E S T H E T I C S
This commit is contained in:
thankyouverycool 2022-12-25 15:41:33 -05:00 • committed by Andreas Kling
parent 5b02e6a46b
commit d938b9effe
10 changed files with 30 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGUI/IconView.cpp
View file

@ -238,7 +238,7 @@ void IconView::mouseup_event(MouseEvent& event)
{
if (m_rubber_banding && event.button() == MouseButton::Primary) {
m_rubber_banding = false;
set_automatic_scrolling_timer(false);
set_automatic_scrolling_timer_active(false);
update(to_widget_rect(Gfx::IntRect::from_two_points(m_rubber_band_origin, m_rubber_band_current)));
}
AbstractView::mouseup_event(event);
@ -329,7 +329,7 @@ void IconView::mousemove_event(MouseEvent& event)
if (m_rubber_banding) {
m_out_of_view_position = event.position();
set_automatic_scrolling_timer(!m_rubber_band_scroll_delta.is_null());
set_automatic_scrolling_timer_active(!m_rubber_band_scroll_delta.is_null());
if (update_rubber_banding(event.position()))
return;
@ -338,9 +338,9 @@ void IconView::mousemove_event(MouseEvent& event)
AbstractView::mousemove_event(event);
}
void IconView::on_automatic_scrolling_timer_fired()
void IconView::automatic_scrolling_timer_did_fire()
{
AbstractView::on_automatic_scrolling_timer_fired();
AbstractView::automatic_scrolling_timer_did_fire();
if (m_rubber_band_scroll_delta.is_null())
return;