RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

LibWeb: Make it clearer that several line-styles are not implemented

Browse source
This commit is contained in:
Sam Atkins 2023-08-02 16:35:07 +01:00 • committed by Andreas Kling
parent 14e6bae593
commit d98bc0da87
1 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibWeb/Painting/BorderPainting.cpp
View file

@ -127,10 +127,27 @@ void paint_border(PaintContext& context, BorderEdge edge, DevicePixelRect const&
}; };
auto gfx_line_style = Gfx::Painter::LineStyle::Solid; auto gfx_line_style = Gfx::Painter::LineStyle::Solid;
if (border_style == CSS::LineStyle::Dotted) switch (border_style) {
case CSS::LineStyle::None:
case CSS::LineStyle::Hidden:
return;
case CSS::LineStyle::Dotted:
gfx_line_style = Gfx::Painter::LineStyle::Dotted; gfx_line_style = Gfx::Painter::LineStyle::Dotted;
if (border_style == CSS::LineStyle::Dashed) break;
case CSS::LineStyle::Dashed:
gfx_line_style = Gfx::Painter::LineStyle::Dashed; gfx_line_style = Gfx::Painter::LineStyle::Dashed;
break;
case CSS::LineStyle::Solid:
gfx_line_style = Gfx::Painter::LineStyle::Solid;
break;
case CSS::LineStyle::Double:
case CSS::LineStyle::Groove:
case CSS::LineStyle::Ridge:
case CSS::LineStyle::Inset:
case CSS::LineStyle::Outset:
// FIXME: Implement these
break;
}
if (gfx_line_style != Gfx::Painter::LineStyle::Solid) { if (gfx_line_style != Gfx::Painter::LineStyle::Solid) {
auto [p1, p2] = points_for_edge(edge, rect); auto [p1, p2] = points_for_edge(edge, rect);