From d9cb7b6dc7a3b3359ef2860c91a2a24b0188a720 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Thu, 10 Nov 2022 19:14:37 +0000 Subject: [PATCH] LibIDL: Fix accidental early return in resolve_typedef() This made sense before we had the next step to resolve union types, but now we only need to skip transferring the extended attributes, without returning just yet. --- Userland/Libraries/LibIDL/IDLParser.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibIDL/IDLParser.cpp b/Userland/Libraries/LibIDL/IDLParser.cpp index b616cc8dbf..44f803352a 100644 --- a/Userland/Libraries/LibIDL/IDLParser.cpp +++ b/Userland/Libraries/LibIDL/IDLParser.cpp @@ -831,10 +831,10 @@ static void resolve_typedef(Interface& interface, NonnullRefPtr& type, Has bool nullable = type->is_nullable(); type = it->value.type; type->set_nullable(nullable); - if (!extended_attributes) - return; - for (auto& attribute : it->value.extended_attributes) - extended_attributes->set(attribute.key, attribute.value); + if (extended_attributes) { + for (auto& attribute : it->value.extended_attributes) + extended_attributes->set(attribute.key, attribute.value); + } // Recursively resolve typedefs in unions after we resolved the type itself - e.g. for this: // typedef (A or B) Union1;