mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 16:57:35 +00:00
LibJS: Don't handle arrays separately in Value::to_number()
Now that Array.prototype.join() is producing the correct results we can remove the separate code path for arrays in Value::to_number() and treat them like all other objects - using to_primitive() with number as the preferred type and then calling to_number() on the result. This is how the spec descibes it. This also means we don't crash anymore when trying to coerce [<empty>] to a number - it now does the following: [<empty>] - to string - "" - to number - 0 [<empty>, <empty>] - to string - "," - to number - NaN
This commit is contained in:
parent
6d6cd64689
commit
da0ab16f01
2 changed files with 13 additions and 12 deletions
|
@ -162,16 +162,7 @@ Value Value::to_number() const
|
|||
case Type::Undefined:
|
||||
return js_nan();
|
||||
case Type::Object:
|
||||
if (m_value.as_object->is_array()) {
|
||||
auto& array = *static_cast<Array*>(m_value.as_object);
|
||||
if (array.length() == 0)
|
||||
return Value(0);
|
||||
if (array.length() > 1)
|
||||
return js_nan();
|
||||
return array.elements()[0].to_number();
|
||||
} else {
|
||||
return m_value.as_object->to_primitive(Object::PreferredType::Number).to_number();
|
||||
}
|
||||
return m_value.as_object->to_primitive(Object::PreferredType::Number).to_number();
|
||||
}
|
||||
|
||||
ASSERT_NOT_REACHED();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue