RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:38:11 +00:00
Code Issues Activity Actions

AK: Ensure short String instances are valid UTF-8

Browse source 
We are currently only validating long strings.
This commit is contained in:
Timothy Flynn 2023-03-03 09:03:45 -05:00 • committed by Tim Flynn
parent 434ca78425
commit da0d000909
3 changed files with 37 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/AK/TestString.cpp
View file

@ -140,6 +140,26 @@ TEST_CASE(long_streams)
}
}
TEST_CASE(invalid_utf8)
{
auto string1 = String::from_utf8("long string \xf4\x8f\xbf\xc0"sv); // U+110000
EXPECT(string1.is_error());
EXPECT(string1.error().string_literal().contains("Input was not valid UTF-8"sv));
auto string2 = String::from_utf8("\xf4\xa1\xb0\xbd"sv); // U+121C3D
EXPECT(string2.is_error());
EXPECT(string2.error().string_literal().contains("Input was not valid UTF-8"sv));
AllocatingMemoryStream stream;
MUST(stream.write_value<u8>(0xf4));
MUST(stream.write_value<u8>(0xa1));
MUST(stream.write_value<u8>(0xb0));
MUST(stream.write_value<u8>(0xbd));
auto string3 = String::from_stream(stream, stream.used_buffer_size());
EXPECT_EQ(string3.is_error(), true);
EXPECT(string3.error().string_literal().contains("Input was not valid UTF-8"sv));
}
TEST_CASE(from_code_points)
{
for (u32 code_point = 0; code_point < 0x80; ++code_point) {