From da10ad3f0dad3ce54b9ce840f2e25eeb05e751c8 Mon Sep 17 00:00:00 2001 From: Lenny Maiorani Date: Tue, 3 Aug 2021 12:36:58 -0600 Subject: [PATCH] LibSQL: Use compiler generated default functions Problem: - Clang ToT generates warnings due to user-declared functions causing the implicitly generated assignment operator to not be generated. Solution: - Declare the default constructor `= default`. - Remove the default copy constructor declaration. --- Userland/Libraries/LibSQL/Key.cpp | 5 ----- Userland/Libraries/LibSQL/Key.h | 3 +-- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/Userland/Libraries/LibSQL/Key.cpp b/Userland/Libraries/LibSQL/Key.cpp index aba561acc0..07b7c22be3 100644 --- a/Userland/Libraries/LibSQL/Key.cpp +++ b/Userland/Libraries/LibSQL/Key.cpp @@ -9,11 +9,6 @@ namespace SQL { -Key::Key() - : Tuple() -{ -} - Key::Key(TupleDescriptor const& descriptor) : Tuple(descriptor) { diff --git a/Userland/Libraries/LibSQL/Key.h b/Userland/Libraries/LibSQL/Key.h index 1200497cb4..7a3cb8beab 100644 --- a/Userland/Libraries/LibSQL/Key.h +++ b/Userland/Libraries/LibSQL/Key.h @@ -14,12 +14,11 @@ namespace SQL { class Key : public Tuple { public: - Key(); + Key() = default; explicit Key(TupleDescriptor const&); explicit Key(RefPtr); Key(TupleDescriptor const&, ByteBuffer&, size_t& offset); Key(RefPtr, ByteBuffer&, size_t& offset); - Key(Key const&) = default; RefPtr index() const { return m_index; } [[nodiscard]] virtual size_t data_length() const override { return Tuple::data_length() + sizeof(u32); }