RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:57:35 +00:00
Code Issues Activity Actions

LibPDF: Avoid an unnecessary copy in Filter::decode_ascii85()

Browse source
This commit is contained in:
Lucas CHOLLET 2023-11-11 17:38:15 -05:00 • committed by Andreas Kling
parent e80d3ff518
commit dac703a0b8
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibPDF/Filter.cpp
View file

@ -93,8 +93,8 @@ PDFErrorOr<ByteBuffer> Filter::decode_ascii_hex(ReadonlyBytes bytes)
PDFErrorOr<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes bytes) PDFErrorOr<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes bytes)
{ {
Vector<u8> buff; ByteBuffer buffer;
buff.ensure_capacity(bytes.size()); TRY(buffer.try_ensure_capacity(bytes.size()));
size_t byte_index = 0; size_t byte_index = 0;
@ -107,7 +107,7 @@ PDFErrorOr<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes bytes)
if (bytes[byte_index] == 'z') { if (bytes[byte_index] == 'z') {
byte_index++; byte_index++;
for (int i = 0; i < 4; i++) for (int i = 0; i < 4; i++)
buff.append(0); buffer.append(0);
continue; continue;
} }
@ -125,7 +125,7 @@ PDFErrorOr<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes bytes)
} }
for (size_t i = 0; i < to_write - 1; i++) for (size_t i = 0; i < to_write - 1; i++)
buff.append(reinterpret_cast<u8*>(&number)[3 - i]); buffer.append(reinterpret_cast<u8*>(&number)[3 - i]);
break; break;
} else { } else {
@ -140,10 +140,10 @@ PDFErrorOr<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes bytes)
} }
for (int i = 0; i < 4; i++) for (int i = 0; i < 4; i++)
buff.append(reinterpret_cast<u8*>(&number)[3 - i]); buffer.append(reinterpret_cast<u8*>(&number)[3 - i]);
} }
return TRY(ByteBuffer::copy(buff.span())); return buffer;
} }
PDFErrorOr<ByteBuffer> Filter::decode_png_prediction(Bytes bytes, int bytes_per_row) PDFErrorOr<ByteBuffer> Filter::decode_png_prediction(Bytes bytes, int bytes_per_row)