RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:47:45 +00:00
Code Issues Activity Actions

LibJS: Store and return undefined Symbol description

Browse source 
Instead of the current incorrect behaviour of just defaulting to an
empty string.
This commit is contained in:
Idan Horowitz 2021-06-15 02:40:55 +03:00 • committed by Linus Groh
parent 4aff4249aa
commit dac971b4ae
5 changed files with 17 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Symbol.cpp
View file

@ -10,7 +10,7 @@
namespace JS {
Symbol::Symbol(String description, bool is_global)
Symbol::Symbol(Optional<String> description, bool is_global)
: m_description(move(description))
, m_is_global(is_global)
{
@ -20,12 +20,12 @@ Symbol::~Symbol()
{
}
Symbol* js_symbol(Heap& heap, String description, bool is_global)
Symbol* js_symbol(Heap& heap, Optional<String> description, bool is_global)
{
return heap.allocate_without_global_object<Symbol>(move(description), is_global);
}
Symbol* js_symbol(VM& vm, String description, bool is_global)
Symbol* js_symbol(VM& vm, Optional<String> description, bool is_global)
{
return js_symbol(vm.heap(), move(description), is_global);
}