RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

LibJS: Make Interpreter::run() a void function

Browse source 
With one small exception, this is how we've been using this API already,
and it makes sense: a Program is just a ScopeNode with any number of
statements, which are executed one by one. There's no explicit return
value at the end, only a completion value of the last value-producing
statement, which we then access using VM::last_value() if needed (e.g.
in the REPL).
This commit is contained in:
Linus Groh 2021-03-16 09:09:56 +01:00 • committed by Andreas Kling
parent ef3679f9c3
commit dadf2e8251
3 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -555,10 +555,11 @@ JS::Value Document::run_javascript(const StringView& source, const StringView& f
return JS::js_undefined();
}
auto& interpreter = document().interpreter();
auto result = interpreter.run(interpreter.global_object(), *program);
if (interpreter.exception())
interpreter.vm().clear_exception();
return result;
auto& vm = interpreter.vm();
interpreter.run(interpreter.global_object(), *program);
if (vm.exception())
vm.clear_exception();
return vm.last_value();
}
// https://dom.spec.whatwg.org/#dom-document-createelement