RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

Ports: Do not call ./package.sh from a subshell in ./build_all.sh

Browse source 
This patch ensures that ./package.sh is run in the same shell
This solves compiling issues when building certain ports.

This fix was suggested by linusg in
https://github.com/SerenityOS/serenity/issues/5783#issuecomment-798906817
This commit is contained in:
Tom Needham 2021-03-14 14:27:17 +00:00 • committed by Andreas Kling
parent 26d72d3048
commit daf2e5d335
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Ports/build_all.sh
View file

@ -39,14 +39,14 @@ for file in *; do
fi fi
fi fi
if [ "$verbose" == true ]; then if [ "$verbose" == true ]; then
if $(./package.sh); then if ./package.sh; then
echo "Built ${dirname}." echo "Built ${dirname}."
else else
echo "ERROR: Build of ${dirname} was not successful!" echo "ERROR: Build of ${dirname} was not successful!"
some_failed=true some_failed=true
fi fi
else else
if $(./package.sh > /dev/null 2>&1); then if ./package.sh > /dev/null 2>&1; then
echo "Built ${dirname}." echo "Built ${dirname}."
else else
echo "ERROR: Build of ${dirname} was not successful!" echo "ERROR: Build of ${dirname} was not successful!"