RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:57:43 +00:00
Code Issues Activity Actions

LibWeb: Return TypeError for [HTMLConstructor] IDL constructors

Browse source 
This matches the spec since there can be no matching custom element
definition if we don't support custom elements yet.
This commit is contained in:
Srikavin Ramkumar 2023-03-23 04:01:05 -04:00 • committed by Andreas Kling
parent 6bc6ea8e97
commit daf421846c
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -3011,6 +3011,15 @@ JS::ThrowCompletionOr<JS::NonnullGCPtr<JS::Object>> @constructor_class@::constru
generator.set("constructor.length", "0"); generator.set("constructor.length", "0");
generator.append(R"~~~( generator.append(R"~~~(
return vm().throw_completion<JS::TypeError>(JS::ErrorType::NotAConstructor, "@namespaced_name@"); return vm().throw_completion<JS::TypeError>(JS::ErrorType::NotAConstructor, "@namespaced_name@");
)~~~");
} else if (interface.constructors.find_if([](auto const& x) { return x.extended_attributes.contains("HTMLConstructor"); }) != interface.constructors.end()) {
// https://html.spec.whatwg.org/multipage/dom.html#htmlconstructor
VERIFY(interface.constructors.size() == 1);
// FIXME: Properly implement HTMLConstructor extended attribute once custom elements are implemented
generator.set("constructor.length", "0");
generator.append(R"~~~(
return vm().throw_completion<JS::TypeError>(JS::ErrorType::NotAConstructor, "@namespaced_name@");
)~~~"); )~~~");
} else if (interface.constructors.size() == 1) { } else if (interface.constructors.size() == 1) {
// Single constructor // Single constructor