From daf74838ddae1d92c19a17fa7593e118cdcb14d3 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Fri, 22 May 2020 23:17:10 +0100 Subject: [PATCH] LibJS: Add missing exception check to ArrayPrototype's for_each_item() Object::get_by_index() cannot throw for positive indices *right now*, but once we implement descriptors for array index properties, it can. --- Libraries/LibJS/Runtime/ArrayPrototype.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Libraries/LibJS/Runtime/ArrayPrototype.cpp b/Libraries/LibJS/Runtime/ArrayPrototype.cpp index 983e4c36b6..99eff4869b 100644 --- a/Libraries/LibJS/Runtime/ArrayPrototype.cpp +++ b/Libraries/LibJS/Runtime/ArrayPrototype.cpp @@ -111,6 +111,8 @@ static void for_each_item(Interpreter& interpreter, const String& name, AK::Func for (size_t i = 0; i < initial_length; ++i) { auto value = this_object->get_by_index(i); + if (interpreter.exception()) + return; if (value.is_empty()) { if (skip_empty) continue;