RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:17:35 +00:00
Code Issues Activity Actions

LibJS: Match spec behaviour in TypedArray.prototype.join

Browse source 
This corrects 2 TRYs to MUSTs and a replaces a call to is_nullish to
is_undefined.
This commit is contained in:
Jamie Mansfield 2022-11-19 12:47:48 +00:00 • committed by Linus Groh
parent 5341af6225
commit db00097700
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp
View file

@ -761,12 +761,12 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::join)
builder.append(separator); builder.append(separator);
// b. Let element be ! Get(O, ! ToString(𝔽(k))). // b. Let element be ! Get(O, ! ToString(𝔽(k))).
auto element = TRY(typed_array->get(i)); auto element = MUST(typed_array->get(i));
// c. If element is undefined, let next be the empty String; otherwise, let next be ! ToString(element). // c. If element is undefined, let next be the empty String; otherwise, let next be ! ToString(element).
if (element.is_nullish()) if (element.is_undefined())
continue; continue;
auto next = TRY(element.to_string(vm)); auto next = MUST(element.to_string(vm));
// d. Set R to the string-concatenation of R and next. // d. Set R to the string-concatenation of R and next.
builder.append(next); builder.append(next);