RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:57:34 +00:00
Code Issues Activity Actions

LibGfx: Use some AK/Math helpers in AffineTransform

Browse source 
This makes us use AK::sincos and AK::hypot
This commit is contained in:
Hendiadyoin1 2022-04-13 21:56:13 +02:00 • committed by Linus Groh
parent 5fd49b9d9f
commit db0ba9f647
1 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibGfx/AffineTransform.cpp
View file

@ -21,20 +21,14 @@ bool AffineTransform::is_identity_or_translation() const
return a() == 1 && b() == 0 && c() == 0 && d() == 1; return a() == 1 && b() == 0 && c() == 0 && d() == 1;
} }
static float hypotenuse(float x, float y)
{
// FIXME: This won't handle overflow :(
return sqrtf(x * x + y * y);
}
float AffineTransform::x_scale() const float AffineTransform::x_scale() const
{ {
return hypotenuse(m_values[0], m_values[1]); return AK::hypot(m_values[0], m_values[1]);
} }
float AffineTransform::y_scale() const float AffineTransform::y_scale() const
{ {
return hypotenuse(m_values[2], m_values[3]); return AK::hypot(m_values[2], m_values[3]);
} }
FloatPoint AffineTransform::scale() const FloatPoint AffineTransform::scale() const
@ -124,8 +118,9 @@ AffineTransform& AffineTransform::multiply(AffineTransform const& other)
AffineTransform& AffineTransform::rotate_radians(float radians) AffineTransform& AffineTransform::rotate_radians(float radians)
{ {
float sin_angle = sinf(radians); float sin_angle;
float cos_angle = cosf(radians); float cos_angle;
AK::sincos(radians, sin_angle, cos_angle);
AffineTransform rotation(cos_angle, sin_angle, -sin_angle, cos_angle, 0, 0); AffineTransform rotation(cos_angle, sin_angle, -sin_angle, cos_angle, 0, 0);
multiply(rotation); multiply(rotation);
return *this; return *this;