1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 18:25:08 +00:00

LibWeb: Initialize static web strings during main-thread VM creation

These are currently initialized in a [[gnu::constructor]], which has a
weird initialization order. These constructors are invoked before main()
and, incidentally, before any user-defined default constructors of the
static strings they are initializing.

This will become an issue when these strings are ported to FlyString,
which has a user-defined default constructor. In that scenario, when the
FlyString constructor is executed after the [[gnu::constructor]], the
strings will be "reset" to the empty string.

Instead of relying on a non-standard compiler extension here, let's just
initialize these strings explicitly during main-thread VM creation, as
this now happens in WebContent's main().
This commit is contained in:
Timothy Flynn 2023-03-18 10:39:37 -04:00 committed by Jelle Raaijmakers
parent 0d0b87fd46
commit db2ba5f1d9
19 changed files with 74 additions and 27 deletions

View file

@ -7,6 +7,7 @@
#pragma once
#include <AK/DeprecatedFlyString.h>
#include <AK/Error.h>
namespace Web {
namespace HTML {
@ -233,6 +234,8 @@ namespace AttributeNames {
ENUMERATE_HTML_ATTRIBUTES
#undef __ENUMERATE_HTML_ATTRIBUTE
ErrorOr<void> initialize_strings();
}
bool is_boolean_attribute(DeprecatedFlyString const& attribute);