RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 20:25:07 +00:00
Code Issues Activity Actions

Kernel: Tidy up ProcessProcFSTraits construction a bit more

Browse source 
Let the constructor take a Process& instead of a WeakPtr<Process> and
avoid a bunch of WeakPtr copying.
This commit is contained in:
Andreas Kling 2021-09-07 12:27:10 +02:00
parent b481132418
commit db2e67fd53
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Process.cpp
View file

@ -268,7 +268,7 @@ KResult Process::attach_resources(NonnullOwnPtr<Memory::AddressSpace>&& prealloc
first_thread->detach();
}
m_procfs_traits = TRY(ProcessProcFSTraits::try_create({}, make_weak_ptr()));
m_procfs_traits = TRY(ProcessProcFSTraits::try_create({}, *this));
return KSuccess;
}

6
Kernel/Process.h
View file

@ -718,7 +718,7 @@ public:
class ProcessProcFSTraits : public ProcFSExposedComponent {
public:
static KResultOr<NonnullRefPtr<ProcessProcFSTraits>> try_create(Badge<Process>, WeakPtr<Process> process)
static KResultOr<NonnullRefPtr<ProcessProcFSTraits>> try_create(Badge<Process>, Process& process)
{
return adopt_nonnull_ref_or_enomem(new (nothrow) ProcessProcFSTraits(process));
}
@ -732,8 +732,8 @@ public:
virtual GroupID owner_group() const override;
private:
ProcessProcFSTraits(WeakPtr<Process> process)
: m_process(process)
explicit ProcessProcFSTraits(Process& process)
: m_process(process.make_weak_ptr())
{
}