RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:48:11 +00:00
Code Issues Activity Actions

LibLine: Avoid returning reference to cached suggestion

Browse source 
This caused a dangling reference down the line, which lead to funny
things like the following:
    > cd Bui[tab]
    > cd Bui^@^@

By returning a direct reference to the suggestion in question, we can be
sure that the referenced object is alive until the next suggestion
cycle.
This commit is contained in:
Ali Mohammad Pur 2023-12-22 00:44:24 +03:30 • committed by Andreas Kling
parent 64616d3997
commit db34ee357d
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibLine/SuggestionManager.cpp
View file

@ -76,9 +76,10 @@ void SuggestionManager::previous()
CompletionSuggestion const& SuggestionManager::suggest() CompletionSuggestion const& SuggestionManager::suggest()
{ {
m_last_shown_suggestion = m_suggestions[m_next_suggestion_index]; auto const& suggestion = m_suggestions[m_next_suggestion_index];
m_selected_suggestion_index = m_next_suggestion_index; m_selected_suggestion_index = m_next_suggestion_index;
return m_last_shown_suggestion; m_last_shown_suggestion = suggestion;
return suggestion;
} }
void SuggestionManager::set_current_suggestion_initiation_index(size_t index) void SuggestionManager::set_current_suggestion_initiation_index(size_t index)