RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 17:32:44 +00:00
Code Issues Activity Actions

LibCrypto: Use default instead of an empty constructor/destructor

Browse source 
Default implementations allow for more optimizations.
See: https://pvs-studio.com/en/docs/warnings/v832/
This commit is contained in:
Brian Gianforcaro 2021-09-15 23:32:51 -07:00 • committed by Andreas Kling
parent 5dbc72a158
commit dba5710efa
6 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCrypto/Cipher/Mode/CBC.h
View file

@ -19,7 +19,7 @@ class CBC : public Mode<T> {
public: public:
constexpr static size_t IVSizeInBits = 128; constexpr static size_t IVSizeInBits = 128;
virtual ~CBC() { } virtual ~CBC() = default;
template<typename... Args> template<typename... Args>
explicit constexpr CBC<T>(Args... args) explicit constexpr CBC<T>(Args... args)
: Mode<T>(args...) : Mode<T>(args...)

2
Userland/Libraries/LibCrypto/Cipher/Mode/CTR.h
View file

@ -88,7 +88,7 @@ class CTR : public Mode<T> {
public: public:
constexpr static size_t IVSizeInBits = 128; constexpr static size_t IVSizeInBits = 128;
virtual ~CTR() { } virtual ~CTR() = default;
// Must intercept `Intent`, because AES must always be set to // Must intercept `Intent`, because AES must always be set to
// Encryption, even when decrypting AES-CTR. // Encryption, even when decrypting AES-CTR.

2
Userland/Libraries/LibCrypto/Cipher/Mode/GCM.h
View file

@ -24,7 +24,7 @@ class GCM : public CTR<T, IncrementFunction> {
public: public:
constexpr static size_t IVSizeInBits = 128; constexpr static size_t IVSizeInBits = 128;
virtual ~GCM() { } virtual ~GCM() = default;
template<typename... Args> template<typename... Args>
explicit constexpr GCM<T>(Args... args) explicit constexpr GCM<T>(Args... args)

2
Userland/Libraries/LibCrypto/Cipher/Mode/Mode.h
View file

@ -17,7 +17,7 @@ namespace Cipher {
template<typename T> template<typename T>
class Mode { class Mode {
public: public:
virtual ~Mode() { } virtual ~Mode() = default;
virtual void encrypt(ReadonlyBytes in, Bytes& out, ReadonlyBytes ivec = {}, Bytes* ivec_out = nullptr) = 0; virtual void encrypt(ReadonlyBytes in, Bytes& out, ReadonlyBytes ivec = {}, Bytes* ivec_out = nullptr) = 0;
virtual void decrypt(ReadonlyBytes in, Bytes& out, ReadonlyBytes ivec = {}) = 0; virtual void decrypt(ReadonlyBytes in, Bytes& out, ReadonlyBytes ivec = {}) = 0;

4
Userland/Libraries/LibCrypto/PK/PK.h
View file

@ -25,9 +25,7 @@ public:
{ {
} }
PKSystem() PKSystem() = default;
{
}
virtual void encrypt(ReadonlyBytes in, Bytes& out) = 0; virtual void encrypt(ReadonlyBytes in, Bytes& out) = 0;
virtual void decrypt(ReadonlyBytes in, Bytes& out) = 0; virtual void decrypt(ReadonlyBytes in, Bytes& out) = 0;

4
Userland/Libraries/LibCrypto/PK/RSA.h
View file

@ -60,9 +60,7 @@ public:
{ {
} }
RSAPrivateKey() RSAPrivateKey() = default;
{
}
const Integer& modulus() const { return m_modulus; } const Integer& modulus() const { return m_modulus; }
const Integer& private_exponent() const { return m_private_exponent; } const Integer& private_exponent() const { return m_private_exponent; }