RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:38:11 +00:00
Code Issues Activity Actions

LibWeb/HTML: Sniff text or binary resources in HTMLObjectElement

Browse source
This commit is contained in:
Kemal Zebari 2024-02-01 17:11:43 -08:00 • committed by Tim Flynn
parent 8e5410347b
commit dbb3c07e56
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -16,6 +16,7 @@
#include <LibWeb/Layout/ImageBox.h> #include <LibWeb/Layout/ImageBox.h>
#include <LibWeb/Loader/ResourceLoader.h> #include <LibWeb/Loader/ResourceLoader.h>
#include <LibWeb/MimeSniff/MimeType.h> #include <LibWeb/MimeSniff/MimeType.h>
#include <LibWeb/MimeSniff/Resource.h>
namespace Web::HTML { namespace Web::HTML {
@ -181,7 +182,17 @@ void HTMLObjectElement::resource_did_load()
// 1. Let binary be false. // 1. Let binary be false.
bool binary = false; bool binary = false;
// FIXME: 2. If the type specified in the resource's Content-Type metadata is "text/plain", and the result of applying the rules for distinguishing if a resource is text or binary to the resource is that the resource is not text/plain, then set binary to true. // 2. If the type specified in the resource's Content-Type metadata is "text/plain", and the result of applying the rules for distinguishing if a resource is text or binary to the resource is that the resource is not text/plain, then set binary to true.
if (it->value == "text/plain"sv) {
auto supplied_type = MimeSniff::MimeType::parse(it->value).release_value_but_fixme_should_propagate_errors();
auto computed_type = MimeSniff::Resource::sniff(resource()->encoded_data(), MimeSniff::SniffingConfiguration {
.sniffing_context = MimeSniff::SniffingContext::TextOrBinary,
.supplied_type = move(supplied_type),
})
.release_value_but_fixme_should_propagate_errors();
if (computed_type.essence() != "text/plain"sv)
binary = true;
}
// 3. If the type specified in the resource's Content-Type metadata is "application/octet-stream", then set binary to true. // 3. If the type specified in the resource's Content-Type metadata is "application/octet-stream", then set binary to true.
if (it->value == "application/octet-stream"sv) if (it->value == "application/octet-stream"sv)