RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:17:34 +00:00
Code Issues Activity Actions

LibJS: Combine two declarative record traversals in GlobalEnvironment

Browse source 
In GlobalEnvironment::get_binding_value(), we can avoid an extra walk
of the declarative environment record if has_binding() returns a
cacheable environment coordinate.
This commit is contained in:
Andreas Kling 2023-06-11 19:49:48 +02:00
parent 620c495d31
commit dbcf63e85e
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/GlobalEnvironment.cpp
View file

@ -116,8 +116,11 @@ ThrowCompletionOr<Value> GlobalEnvironment::get_binding_value(VM& vm, Deprecated
{ {
// 1. Let DclRec be envRec.[[DeclarativeRecord]]. // 1. Let DclRec be envRec.[[DeclarativeRecord]].
// 2. If ! DclRec.HasBinding(N) is true, then // 2. If ! DclRec.HasBinding(N) is true, then
if (MUST(m_declarative_record->has_binding(name))) { Optional<size_t> index;
if (MUST(m_declarative_record->has_binding(name, &index))) {
// a. Return ? DclRec.GetBindingValue(N, S). // a. Return ? DclRec.GetBindingValue(N, S).
if (index.has_value())
return m_declarative_record->get_binding_value_direct(vm, index.value(), strict);
return m_declarative_record->get_binding_value(vm, name, strict); return m_declarative_record->get_binding_value(vm, name, strict);
} }