1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 07:15:07 +00:00

LibCore: Don't auto-accept events that hit bubbling limit

We were using the "accept" flag on the event to break out of the
bubbling loop, but this had lasting consequences since all events that
bubbled too far came out looking as if someone had accepted them.

If an event is ignored by everyone, it should appear ignored.
This commit is contained in:
Andreas Kling 2021-01-09 00:01:11 +01:00
parent 094b47971b
commit dbd090fd95

View file

@ -231,8 +231,7 @@ void Object::dispatch_event(Core::Event& e, Object* stay_within)
target = target->parent();
if (target == stay_within) {
// Prevent the event from bubbling any further.
e.accept();
break;
return;
}
} while (target && !e.is_accepted());
}