RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 02:28:12 +00:00
Code Issues Activity Actions

LibCore+Userland+Tests: Convert Stream APIs to construct on heap

Browse source 
As per previous discussion, it was decided that the Stream classes
should be constructed on the heap.

While I don't personally agree with this change, it does have the
benefit of avoiding Function object reconstructions due to the lambda
passed to Notifier pointing to a stale object reference. This also has
the benefit of not having to "box" objects for virtual usage, as the
objects come pre-boxed.

However, it means that we now hit the heap everytime we construct a
TCPSocket for instance, which might not be desirable.
This commit is contained in:
sin-ack 2021-12-29 22:31:45 +00:00 • committed by Ali Mohammad Pur
parent eb389db92c
commit dbd25916a3
14 changed files with 163 additions and 162 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/TCPServer.h
View file

@ -24,7 +24,7 @@ public:
ErrorOr<void> listen(IPv4Address const& address, u16 port);
ErrorOr<void> set_blocking(bool blocking);
ErrorOr<Stream::TCPSocket> accept();
ErrorOr<NonnullOwnPtr<Stream::TCPSocket>> accept();
Optional<IPv4Address> local_address() const;
Optional<u16> local_port() const;