From dbdbfbeebc4d55d9759958d930e172e188abff87 Mon Sep 17 00:00:00 2001
From: Linus Groh <mail@linusgroh.de>
Date: Thu, 15 Jul 2021 23:51:02 +0100
Subject: [PATCH] LibJS: Implement Temporal.Duration.prototype.minutes

---
 .../Libraries/LibJS/Runtime/CommonPropertyNames.h  |  1 +
 .../LibJS/Runtime/Temporal/DurationPrototype.cpp   | 14 ++++++++++++++
 .../LibJS/Runtime/Temporal/DurationPrototype.h     |  1 +
 .../Duration/Duration.prototype.minutes.js         | 14 ++++++++++++++
 4 files changed, 30 insertions(+)
 create mode 100644 Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.minutes.js

diff --git a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
index 9f0fab4efd..f494a74ba2 100644
--- a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
+++ b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
@@ -238,6 +238,7 @@ namespace JS {
     P(max)                                   \
     P(message)                               \
     P(min)                                   \
+    P(minutes)                               \
     P(months)                                \
     P(multiline)                             \
     P(name)                                  \
diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
index ae8495e715..9d6b9365e7 100644
--- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
+++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
@@ -30,6 +30,7 @@ void DurationPrototype::initialize(GlobalObject& global_object)
     define_native_accessor(vm.names.weeks, weeks_getter, {}, Attribute::Configurable);
     define_native_accessor(vm.names.days, days_getter, {}, Attribute::Configurable);
     define_native_accessor(vm.names.hours, hours_getter, {}, Attribute::Configurable);
+    define_native_accessor(vm.names.minutes, minutes_getter, {}, Attribute::Configurable);
 }
 
 static Duration* typed_this(GlobalObject& global_object)
@@ -110,4 +111,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::hours_getter)
     return Value(duration->hours());
 }
 
+// 7.3.8 get Temporal.Duration.prototype.minutes, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.minutes
+JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::minutes_getter)
+{
+    // 1. Let duration be the this value.
+    // 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
+    auto* duration = typed_this(global_object);
+    if (vm.exception())
+        return {};
+
+    // 3. Return duration.[[Minutes]].
+    return Value(duration->minutes());
+}
+
 }
diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
index 946bb53d6a..e5e8facf9a 100644
--- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
+++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
@@ -24,6 +24,7 @@ private:
     JS_DECLARE_NATIVE_FUNCTION(weeks_getter);
     JS_DECLARE_NATIVE_FUNCTION(days_getter);
     JS_DECLARE_NATIVE_FUNCTION(hours_getter);
+    JS_DECLARE_NATIVE_FUNCTION(minutes_getter);
 };
 
 }
diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.minutes.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.minutes.js
new file mode 100644
index 0000000000..8ef450dc46
--- /dev/null
+++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.minutes.js
@@ -0,0 +1,14 @@
+describe("correct behavior", () => {
+    test("basic functionality", () => {
+        const duration = new Temporal.Duration(0, 0, 0, 0, 0, 123);
+        expect(duration.minutes).toBe(123);
+    });
+});
+
+test("errors", () => {
+    test("this value must be a Temporal.Duration object", () => {
+        expect(() => {
+            Reflect.get(Temporal.Duration.prototype, "minutes", "foo");
+        }).toThrowWithMessage(TypeError, "Not a Temporal.Duration");
+    });
+});