RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:17:44 +00:00
Code Issues Activity Actions

LibJS: Remove the VM parameter from the NumberToString AO

Browse source 
This will be needed by Value::to_string_without_side_effects, which can
be called in contexts without a VM (e.g. in AK::Format specializations).
So to_string_without_side_effects will need to be callable without a VM,
thus NumberToString must be as well.
This commit is contained in:
Timothy Flynn 2023-02-12 21:05:42 -05:00 • committed by Linus Groh
parent 7a7a649f5b
commit dc4207323b
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Intl/MathematicalValue.cpp
View file

@ -297,8 +297,8 @@ bool MathematicalValue::is_zero() const
ThrowCompletionOr<String> MathematicalValue::to_string(VM& vm) const
{
return m_value.visit(
[&](double value) {
return number_to_string(vm, value, NumberToStringMode::WithoutExponent);
[&](double value) -> ThrowCompletionOr<String> {
return TRY_OR_THROW_OOM(vm, number_to_string(value, NumberToStringMode::WithoutExponent));
},
[&](Crypto::SignedBigInteger const& value) -> ThrowCompletionOr<String> {
return TRY_OR_THROW_OOM(vm, value.to_base(10));