RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-29 20:35:13 +00:00
Code Issues Activity Actions

Shell: Avoid waiting for jobs that were *just* unblocked

Browse source 
This fixes the issue with C-z not suspending the job on the first try.
...and further signal issues when the suspended job is contiued.
This commit is contained in:
AnotherTest 2020-07-13 20:29:52 +04:30 • committed by Andreas Kling
parent 46661f02c6
commit dc62371439
4 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Shell/Shell.cpp
View file

@ -561,16 +561,18 @@ Vector<RefPtr<Job>> Shell::run_commands(Vector<AST::Command>& commands)
}
#endif
auto job = run_command(command);
if (!job)
continue;
if (command.should_wait) {
block_on_job(job);
jobs_to_wait_for.append(job);
if (!job->is_suspended())
jobs_to_wait_for.append(job);
} else {
if (command.is_pipe_source) {
jobs_to_wait_for.append(job);
} else if (command.should_notify_if_in_background) {
if (job)
job->set_running_in_background(true);
job->set_running_in_background(true);
restore_stdin();
}
}