RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:57:45 +00:00
Code Issues Activity Actions

WindowServer: Don't send Paint messages to minimized windows.

Browse source 
There's no point in painting if it can't be seen anyway. We also make sure
to request a repaint when un-minimizing, so the window gets a chance to
repaint itself then.
This commit is contained in:
Andreas Kling 2019-05-04 23:57:23 +02:00
parent 48e3ea9e5c
commit dc919352b0
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Servers/WindowServer/WSClientConnection.cpp
View file

@ -510,10 +510,12 @@ void WSClientConnection::handle_request(const WSAPIDestroyWindowRequest& request
void WSClientConnection::post_paint_message(WSWindow& window)
{
auto rect_set = window.take_pending_paint_rects();
if (window.is_minimized())
return;
WSAPI_ServerMessage message;
message.type = WSAPI_ServerMessage::Type::Paint;
message.window_id = window.window_id();
auto rect_set = window.take_pending_paint_rects();
auto& rects = rect_set.rects();
message.rect_count = rects.size();
for (int i = 0; i < min(WSAPI_ServerMessage::max_inline_rect_count, rects.size()); ++i)

2
Servers/WindowServer/WSWindow.cpp
View file

@ -128,6 +128,8 @@ void WSWindow::set_minimized(bool minimized)
if (m_minimized == minimized)
return;
m_minimized = minimized;
if (!minimized)
request_update({ { }, size() });
invalidate();
WSWindowManager::the().notify_minimization_state_changed(*this);
}