RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 21:08:12 +00:00
Code Issues Activity Actions

LibJS: Accept calendar names case-insensitively

Browse source 
This is a normative change in the Temporal spec

See tc39/proposal-temporal@03101c6
This commit is contained in:
Yedaya Katsman 2022-10-24 23:20:44 +03:00 • committed by Linus Groh
parent b00d49bbf0
commit dcad8494d6
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp
View file

@ -37,9 +37,11 @@ bool is_builtin_calendar(String const& identifier)
// 1. Let calendars be AvailableCalendars().
auto calendars = available_calendars();
// 2. If calendars contains id, return true.
if (calendars.contains_slow(identifier))
return true;
// 2. If calendars contains the ASCII-lowercase of id, return true.
for (auto calendar : calendars) {
if (calendar.equals_ignoring_case(identifier))
return true;
}
// 3. Return false.
return false;
@ -73,8 +75,8 @@ ThrowCompletionOr<Calendar*> create_temporal_calendar(VM& vm, String const& iden
new_target = realm.intrinsics().temporal_calendar_constructor();
// 3. Let object be ? OrdinaryCreateFromConstructor(newTarget, "%Temporal.Calendar.prototype%", « [[InitializedTemporalCalendar]], [[Identifier]] »).
// 4. Set object.[[Identifier]] to identifier.
auto* object = TRY(ordinary_create_from_constructor<Calendar>(vm, *new_target, &Intrinsics::temporal_calendar_prototype, identifier));
// 4. Set object.[[Identifier]] to the ASCII-lowercase of identifier.
auto* object = TRY(ordinary_create_from_constructor<Calendar>(vm, *new_target, &Intrinsics::temporal_calendar_prototype, identifier.to_lowercase()));
// 5. Return object.
return object;