RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:27:45 +00:00
Code Issues Activity Actions

Meta/gn: Don't use "abspath" for IDL inputs

Browse source 
The idl file lists are used for two things:

1. As inputs for `generate_window_or_worker_interfaces`
2. In a loop in `generate_idl_bindings` and the loop variable
   is passed to `rebase_path`

Both these cases can handle a normal fully-qualified GN path,
so there's no need for the "abspath".

No behavior change.
This commit is contained in:
Nico Weber 2023-07-27 10:16:39 -04:00 • committed by Andrew Kaster
parent 406b68a612
commit dcb2f3aa89
2 changed files with 260 additions and 270 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Meta/gn/secondary/Userland/Libraries/LibWeb/generate_idl_bindings.gni
View file

@ -12,19 +12,16 @@
# Parameters: # Parameters:
# idl_list (required) [string] # idl_list (required) [string]
# List of IDL files that are all the same type. # List of IDL files that are all the same type.
# Expected to be an absolute path.
# #
# type (required) string # type (required) string
# "global", "iterable", "namespace", or "standard" # "global", "iterable", "namespace", or "standard"
# #
# Example use: # Example use:
# #
# standard_idl_files = get_path_info( # standard_idl_files = [
# [
# "//Library/Foo.idl", # "//Library/Foo.idl",
# "//Bar.idl" # "//Bar.idl"
# ], # ]
# "abspath")
# #
# generate_idl_bindings("standard_idl_bindings") { # generate_idl_bindings("standard_idl_bindings") {
# idl_list = standard_idl_files # idl_list = standard_idl_files

21
Meta/gn/secondary/Userland/Libraries/LibWeb/idl_files.gni
View file

@ -4,27 +4,21 @@
# Most IDL files are going to be "standard". # Most IDL files are going to be "standard".
# #
iterable_idl_files = iterable_idl_files = [
get_path_info([
"//Userland/Libraries/LibWeb/Fetch/Headers.idl", "//Userland/Libraries/LibWeb/Fetch/Headers.idl",
"//Userland/Libraries/LibWeb/URL/URLSearchParams.idl", "//Userland/Libraries/LibWeb/URL/URLSearchParams.idl",
"//Userland/Libraries/LibWeb/XHR/FormData.idl", "//Userland/Libraries/LibWeb/XHR/FormData.idl",
], ]
"abspath")
namespace_idl_files = namespace_idl_files = [
get_path_info([
"//Userland/Libraries/LibWeb/CSS/CSS.idl", "//Userland/Libraries/LibWeb/CSS/CSS.idl",
"//Userland/Libraries/LibWeb/WebAssembly/WebAssembly.idl", "//Userland/Libraries/LibWeb/WebAssembly/WebAssembly.idl",
], ]
"abspath")
global_idl_files = global_idl_files = [ "//Userland/Libraries/LibWeb/HTML/Window.idl" ]
get_path_info([ "//Userland/Libraries/LibWeb/HTML/Window.idl" ], "abspath")
# Standard idl files are neither iterable, namespaces, or global # Standard idl files are neither iterable, namespaces, or global
standard_idl_files = get_path_info( standard_idl_files = [
[
"//Userland/Libraries/LibWeb/Crypto/Crypto.idl", "//Userland/Libraries/LibWeb/Crypto/Crypto.idl",
"//Userland/Libraries/LibWeb/Crypto/SubtleCrypto.idl", "//Userland/Libraries/LibWeb/Crypto/SubtleCrypto.idl",
"//Userland/Libraries/LibWeb/CSS/CSSConditionRule.idl", "//Userland/Libraries/LibWeb/CSS/CSSConditionRule.idl",
@ -269,5 +263,4 @@ standard_idl_files = get_path_info(
"//Userland/Libraries/LibWeb/XHR/XMLHttpRequest.idl", "//Userland/Libraries/LibWeb/XHR/XMLHttpRequest.idl",
"//Userland/Libraries/LibWeb/XHR/XMLHttpRequestEventTarget.idl", "//Userland/Libraries/LibWeb/XHR/XMLHttpRequestEventTarget.idl",
"//Userland/Libraries/LibWeb/XHR/XMLHttpRequestUpload.idl", "//Userland/Libraries/LibWeb/XHR/XMLHttpRequestUpload.idl",
], ]
"abspath")