RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:27:35 +00:00
Code Issues Activity Actions

Kernel+LibC: Pack SC_setsockopt_params struct tighter

Browse source 
Flagged by pvs-studio, ordering the members from largest to smallest
allows us to save a few bytes in the size of the struct.
This commit is contained in:
Brian Gianforcaro 2021-09-15 23:42:47 -07:00 • committed by Andreas Kling
parent 9956607283
commit dcb327a83b
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -300,10 +300,10 @@ struct SC_getsockopt_params {
};
struct SC_setsockopt_params {
const void* value;
int sockfd;
int level;
int option;
const void* value;
socklen_t value_size;
};

2
Userland/Libraries/LibC/sys/socket.cpp
View file

@ -112,7 +112,7 @@ int getsockopt(int sockfd, int level, int option, void* value, socklen_t* value_
int setsockopt(int sockfd, int level, int option, const void* value, socklen_t value_size)
{
Syscall::SC_setsockopt_params params { sockfd, level, option, value, value_size };
Syscall::SC_setsockopt_params params { value, sockfd, level, option, value_size };
int rc = syscall(SC_setsockopt, &params);
__RETURN_WITH_ERRNO(rc, rc, -1);
}