RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:14:58 +00:00
Code Issues Activity Actions

LibGUI+Browser: Set menu names using the new String class

Browse source
This commit is contained in:
Karol Kosek 2023-04-16 11:36:57 +02:00 • committed by Andreas Kling
parent 956f4d9205
commit dccd70385d
3 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/Browser/BrowserWindow.cpp
View file

@ -810,7 +810,7 @@ ErrorOr<void> BrowserWindow::take_screenshot(ScreenshotType type)
void BrowserWindow::update_displayed_zoom_level()
{
VERIFY(m_zoom_menu);
auto zoom_level_text = DeprecatedString::formatted("&Zoom ({}%)", round_to<int>(active_tab().view().zoom_level() * 100));
auto zoom_level_text = String::formatted("&Zoom ({}%)", round_to<int>(active_tab().view().zoom_level() * 100)).release_value_but_fixme_should_propagate_errors();
m_zoom_menu->set_name(zoom_level_text);
active_tab().update_reset_zoom_button();
}

5
Userland/Libraries/LibGUI/Menu.cpp
View file

@ -89,11 +89,6 @@ void Menu::update_parent_menu_item()
}
}
void Menu::set_name(DeprecatedString name)
{
set_name(String::from_deprecated_string(name).release_value_but_fixme_should_propagate_errors());
}
void Menu::set_name(String name)
{
m_name = move(name);

1
Userland/Libraries/LibGUI/Menu.h
View file

@ -34,7 +34,6 @@ public:
int menu_id() const { return m_menu_id; }
String const& name() const { return m_name; }
void set_name(DeprecatedString);
void set_name(String);
Gfx::Bitmap const* icon() const { return m_icon.ptr(); }