From dccfff8c19003d3539f238fdd2f112bf5b32c242 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 11 Apr 2020 23:15:33 +0200 Subject: [PATCH] ProfileViewer: Don't crash when we can't disassemble something --- DevTools/ProfileViewer/DisassemblyModel.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/DevTools/ProfileViewer/DisassemblyModel.cpp b/DevTools/ProfileViewer/DisassemblyModel.cpp index 37939976ce..52f6552a73 100644 --- a/DevTools/ProfileViewer/DisassemblyModel.cpp +++ b/DevTools/ProfileViewer/DisassemblyModel.cpp @@ -55,9 +55,15 @@ DisassemblyModel::DisassemblyModel(Profile& profile, ProfileNode& node) , m_node(node) { m_file = make(profile.executable_path()); + + if (!m_file->is_valid()) + return; + auto elf_loader = make((const u8*)m_file->data(), m_file->size()); auto symbol = elf_loader->find_symbol(node.address()); + if (!symbol.has_value()) + return; ASSERT(symbol.has_value()); auto view = symbol.value().raw_data();