RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:17:34 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibIPC

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-03 11:37:49 -07:00 • committed by Andreas Kling
parent 79aa49d04f
commit dcdc62323d
9 changed files with 14 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibIPC/CMakeLists.txt
View file

@ -2,8 +2,6 @@ set(SOURCES
Connection.cpp Connection.cpp
Decoder.cpp Decoder.cpp
Encoder.cpp Encoder.cpp
Message.cpp
Stub.cpp
) )
serenity_lib(LibIPC ipc) serenity_lib(LibIPC ipc)

5
Userland/Libraries/LibIPC/Connection.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -19,10 +20,6 @@ ConnectionBase::ConnectionBase(IPC::Stub& local_stub, NonnullOwnPtr<Core::Stream
m_responsiveness_timer = Core::Timer::create_single_shot(3000, [this] { may_have_become_unresponsive(); }); m_responsiveness_timer = Core::Timer::create_single_shot(3000, [this] { may_have_become_unresponsive(); });
} }
ConnectionBase::~ConnectionBase()
{
}
ErrorOr<void> ConnectionBase::post_message(Message const& message) ErrorOr<void> ConnectionBase::post_message(Message const& message)
{ {
return post_message(message.encode()); return post_message(message.encode());

3
Userland/Libraries/LibIPC/Connection.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -30,7 +31,7 @@ class ConnectionBase : public Core::Object {
C_OBJECT_ABSTRACT(ConnectionBase); C_OBJECT_ABSTRACT(ConnectionBase);
public: public:
virtual ~ConnectionBase() override; virtual ~ConnectionBase() override = default;
bool is_open() const { return m_socket->is_open(); } bool is_open() const { return m_socket->is_open(); }
ErrorOr<void> post_message(Message const&); ErrorOr<void> post_message(Message const&);

6
Userland/Libraries/LibIPC/ConnectionFromClient.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -7,6 +8,7 @@
#pragma once #pragma once
#include <LibIPC/Connection.h> #include <LibIPC/Connection.h>
#include <LibIPC/Stub.h>
namespace IPC { namespace IPC {
@ -36,9 +38,7 @@ public:
}; };
} }
virtual ~ConnectionFromClient() override virtual ~ConnectionFromClient() override = default;
{
}
void did_misbehave() void did_misbehave()
{ {

3
Userland/Libraries/LibIPC/Dictionary.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -13,7 +14,7 @@ namespace IPC {
class Dictionary { class Dictionary {
public: public:
Dictionary() { } Dictionary() = default;
Dictionary(const HashMap<String, String>& initial_entries) Dictionary(const HashMap<String, String>& initial_entries)
: m_entries(initial_entries) : m_entries(initial_entries)

19
Userland/Libraries/LibIPC/Message.cpp
View file

@ -1,19 +0,0 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibIPC/Message.h>
namespace IPC {
Message::Message()
{
}
Message::~Message()
{
}
}

5
Userland/Libraries/LibIPC/Message.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -43,7 +44,7 @@ enum class ErrorCode : u32 {
class Message { class Message {
public: public:
virtual ~Message(); virtual ~Message() = default;
virtual u32 endpoint_magic() const = 0; virtual u32 endpoint_magic() const = 0;
virtual int message_id() const = 0; virtual int message_id() const = 0;
@ -52,7 +53,7 @@ public:
virtual MessageBuffer encode() const = 0; virtual MessageBuffer encode() const = 0;
protected: protected:
Message(); Message() = default;
}; };
} }

19
Userland/Libraries/LibIPC/Stub.cpp
View file

@ -1,19 +0,0 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibIPC/Stub.h>
namespace IPC {
Stub::Stub()
{
}
Stub::~Stub()
{
}
}

5
Userland/Libraries/LibIPC/Stub.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -20,14 +21,14 @@ struct MessageBuffer;
class Stub { class Stub {
public: public:
virtual ~Stub(); virtual ~Stub() = default;
virtual u32 magic() const = 0; virtual u32 magic() const = 0;
virtual String name() const = 0; virtual String name() const = 0;
virtual OwnPtr<MessageBuffer> handle(const Message&) = 0; virtual OwnPtr<MessageBuffer> handle(const Message&) = 0;
protected: protected:
Stub(); Stub() = default;
private: private:
String m_name; String m_name;