RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:27:35 +00:00
Code Issues Activity Actions

Shell: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 21:05:02 -06:00 • committed by Brian Gianforcaro
parent 0b7baa7e5a
commit dd05934539
5 changed files with 12 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Userland/Shell/AST.cpp
View file

@ -408,10 +408,6 @@ Vector<Line::CompletionSuggestion> Node::complete_for_editor(Shell& shell, size_
return Node::complete_for_editor(shell, offset, { nullptr, nullptr, nullptr });
}
Node::~Node()
{
}
void And::dump(int level) const
{
Node::dump(level);
@ -463,10 +459,6 @@ And::And(Position position, NonnullRefPtr<Node> left, NonnullRefPtr<Node> right,
set_is_syntax_error(m_right->syntax_error_node());
}
And::~And()
{
}
void ListConcatenate::dump(int level) const
{
Node::dump(level);
@ -580,10 +572,6 @@ ListConcatenate::ListConcatenate(Position position, Vector<NonnullRefPtr<Node>>
}
}
ListConcatenate::~ListConcatenate()
{
}
void Background::dump(int level) const
{
Node::dump(level);
@ -617,10 +605,6 @@ Background::Background(Position position, NonnullRefPtr<Node> command)
set_is_syntax_error(m_command->syntax_error_node());
}
Background::~Background()
{
}
void BarewordLiteral::dump(int level) const
{
Node::dump(level);
@ -673,10 +657,6 @@ BarewordLiteral::BarewordLiteral(Position position, String text)
{
}
BarewordLiteral::~BarewordLiteral()
{
}
void BraceExpansion::dump(int level) const
{
Node::dump(level);
@ -732,10 +712,6 @@ BraceExpansion::BraceExpansion(Position position, NonnullRefPtrVector<Node> entr
}
}
BraceExpansion::~BraceExpansion()
{
}
void CastToCommand::dump(int level) const
{
Node::dump(level);
@ -799,10 +775,6 @@ CastToCommand::CastToCommand(Position position, NonnullRefPtr<Node> inner)
set_is_syntax_error(m_inner->syntax_error_node());
}
CastToCommand::~CastToCommand()
{
}
void CastToList::dump(int level) const
{
Node::dump(level);
@ -865,10 +837,6 @@ CastToList::CastToList(Position position, RefPtr<Node> inner)
set_is_syntax_error(m_inner->syntax_error_node());
}
CastToList::~CastToList()
{
}
void CloseFdRedirection::dump(int level) const
{
Node::dump(level);