From dda9ffe90672de3af1b120cdf596e0c2ba5b1db4 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 13 Apr 2020 11:57:19 +0200 Subject: [PATCH] LibC: Fix truncated strncpy() in /etc/group parsing --- Libraries/LibC/grp.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/LibC/grp.cpp b/Libraries/LibC/grp.cpp index 6d66e76268..f04e5d0545 100644 --- a/Libraries/LibC/grp.cpp +++ b/Libraries/LibC/grp.cpp @@ -140,8 +140,8 @@ next_entry: } __grdb_entry->members[members.size()] = nullptr; __grdb_entry->gr_mem = __grdb_entry->members; - strncpy(__grdb_entry->name_buffer, e_name.characters(), GRDB_STR_MAX_LEN); - strncpy(__grdb_entry->passwd_buffer, e_passwd.characters(), GRDB_STR_MAX_LEN); + strncpy(__grdb_entry->name_buffer, e_name.characters(), GRDB_STR_MAX_LEN - 1); + strncpy(__grdb_entry->passwd_buffer, e_passwd.characters(), GRDB_STR_MAX_LEN - 1); return __grdb_entry; }