RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:07:45 +00:00
Code Issues Activity Actions

Kernel: Store TTY's foreground process as a WeakPtr<Process>

Browse source 
This ensures that we don't leave a stale PGID assigned to the TTY after
the process exits, which would make PID recycling attacks possible.
This commit is contained in:
Andreas Kling 2020-08-06 11:17:53 +02:00
parent ff01cfa08a
commit ddab7ab693
3 changed files with 22 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Kernel/Process.h
View file

@ -35,6 +35,7 @@
#include <AK/String.h>
#include <AK/Userspace.h>
#include <AK/WeakPtr.h>
#include <AK/Weakable.h>
#include <Kernel/API/Syscall.h>
#include <Kernel/FileSystem/InodeMetadata.h>
#include <Kernel/Forward.h>
@ -106,7 +107,11 @@ struct UnveiledPath {
unsigned permissions { 0 };
};
class Process : public RefCounted<Process>, public InlineLinkedListNode<Process> {
class Process
: public RefCounted<Process>
, public InlineLinkedListNode<Process>
, public Weakable<Process> {
AK_MAKE_NONCOPYABLE(Process);
AK_MAKE_NONMOVABLE(Process);
@ -453,7 +458,8 @@ public:
[[nodiscard]] String validate_and_copy_string_from_user(Userspace<const char*> user_characters, size_t size) const
{
return validate_and_copy_string_from_user(user_characters.unsafe_userspace_ptr(), size); }
return validate_and_copy_string_from_user(user_characters.unsafe_userspace_ptr(), size);
}
[[nodiscard]] String validate_and_copy_string_from_user(const Syscall::StringArgument&) const;