RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 19:25:10 +00:00
Code Issues Activity Actions

Kernel: Fix a long-standing problem with GMBus in Intel Grahpics code

Browse source 
Thanks to Andrew Kaster, which gave a review back in October, about a
big PR I opened (#15502), I managed to figure out why we always had a
problem with the first byte being read into the EDID buffer with the
GMBus code. It turns out that this simple invalid cast was making the
entire problem and using the correct AK::Array::data() method fixed this
notorious long standing problem for good.
This commit is contained in:
Liav A 2023-01-28 15:25:13 +02:00 • committed by Andrew Kaster
parent 5220afcf73
commit ddc5c41253
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Graphics/Intel/NativeDisplayConnector.cpp
View file

@ -418,11 +418,7 @@ void IntelNativeDisplayConnector::gmbus_read_edid()
{
SpinlockLocker control_lock(m_control_lock);
gmbus_write(DDC2_I2C_ADDRESS, 0);
gmbus_read(DDC2_I2C_ADDRESS, (u8*)&crt_edid_bytes, sizeof(crt_edid_bytes));
// FIXME: It seems like the returned EDID is almost correct,
// but the first byte is set to 0xD0 instead of 0x00.
// For now, this "hack" works well enough.
crt_edid_bytes[0] = 0x0;
gmbus_read(DDC2_I2C_ADDRESS, crt_edid_bytes.data(), crt_edid_bytes.size());
}
set_edid_bytes(crt_edid_bytes);
}