RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:07:35 +00:00
Code Issues Activity Actions

Change String&& arguments to const String& in a couple of places.

Browse source 
String&& is more nuisance than anything, and the codegen improvement is
basically negligible since the underlying type is already retainable.
This commit is contained in:
Andreas Kling 2019-05-12 14:57:15 +02:00
parent 23e6c45e87
commit dddf45f563
11 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Applications/Terminal/Terminal.cpp
View file

@ -830,12 +830,12 @@ void Terminal::paint_event(GPaintEvent& event)
painter.draw_rect(frame_inner_rect(), Color::Red);
}
void Terminal::set_window_title(String&& title)
void Terminal::set_window_title(const String& title)
{
auto* w = window();
if (!w)
return;
w->set_title(move(title));
w->set_title(title);
}
void Terminal::invalidate_cursor()

2
Applications/Terminal/Terminal.h
View file

@ -40,7 +40,7 @@ private:
void set_cursor(unsigned row, unsigned column);
void put_character_at(unsigned row, unsigned column, byte ch);
void invalidate_cursor();
void set_window_title(String&&);
void set_window_title(const String&);
void inject_string(const String&);
void unimplemented_escape();