RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:47:36 +00:00
Code Issues Activity Actions

Change String&& arguments to const String& in a couple of places.

Browse source 
String&& is more nuisance than anything, and the codegen improvement is
basically negligible since the underlying type is already retainable.
This commit is contained in:
Andreas Kling 2019-05-12 14:57:15 +02:00
parent 23e6c45e87
commit dddf45f563
11 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Servers/WindowServer/WSEvent.h
View file

@ -407,9 +407,9 @@ private:
class WSAPISetWallpaperRequest final : public WSAPIClientRequest {
public:
explicit WSAPISetWallpaperRequest(int client_id, String&& wallpaper)
explicit WSAPISetWallpaperRequest(int client_id, const String& wallpaper)
: WSAPIClientRequest(WSEvent::APISetWallpaperRequest, client_id)
, m_wallpaper(move(wallpaper))
, m_wallpaper(wallpaper)
{
}
@ -429,10 +429,10 @@ public:
class WSAPISetWindowTitleRequest final : public WSAPIClientRequest {
public:
explicit WSAPISetWindowTitleRequest(int client_id, int window_id, String&& title)
explicit WSAPISetWindowTitleRequest(int client_id, int window_id, const String& title)
: WSAPIClientRequest(WSEvent::APISetWindowTitleRequest, client_id)
, m_window_id(window_id)
, m_title(move(title))
, m_title(title)
{
}

2
Servers/WindowServer/WSMenu.cpp
View file

@ -11,7 +11,7 @@
#include <SharedGraphics/StylePainter.h>
#include <SharedGraphics/Font.h>
WSMenu::WSMenu(WSClientConnection* client, int menu_id, String&& name)
WSMenu::WSMenu(WSClientConnection* client, int menu_id, const String& name)
: m_client(client)
, m_menu_id(menu_id)
, m_name(move(name))

2
Servers/WindowServer/WSMenu.h
View file

@ -15,7 +15,7 @@ class Font;
class WSMenu final : public CObject {
public:
WSMenu(WSClientConnection*, int menu_id, String&& name);
WSMenu(WSClientConnection*, int menu_id, const String& name);
virtual ~WSMenu() override;
WSClientConnection* client() { return m_client; }

4
Servers/WindowServer/WSWindow.cpp
View file

@ -50,11 +50,11 @@ WSWindow::~WSWindow()
WSWindowManager::the().remove_window(*this);
}
void WSWindow::set_title(String&& title)
void WSWindow::set_title(const String& title)
{
if (m_title == title)
return;
m_title = move(title);
m_title = title;
WSWindowManager::the().notify_title_changed(*this);
}

2
Servers/WindowServer/WSWindow.h
View file

@ -43,7 +43,7 @@ public:
int window_id() const { return m_window_id; }
String title() const { return m_title; }
void set_title(String&&);
void set_title(const String&);
float opacity() const { return m_opacity; }
void set_opacity(float opacity) { m_opacity = opacity; }