RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:28:10 +00:00
Code Issues Activity Actions

ImageDecoder: Remove unnecessary greet() message

Browse source 
This didn't do anything except induce an IPC stall during startup.
This commit is contained in:
Andreas Kling 2021-05-23 08:48:59 +02:00
parent 6ebec090c3
commit de07dab184
4 changed files with 0 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibImageDecoderClient/Client.cpp
View file

@ -12,7 +12,6 @@ namespace ImageDecoderClient {
Client::Client() Client::Client()
: IPC::ServerConnection<ImageDecoderClientEndpoint, ImageDecoderServerEndpoint>(*this, "/tmp/portal/image") : IPC::ServerConnection<ImageDecoderClientEndpoint, ImageDecoderServerEndpoint>(*this, "/tmp/portal/image")
{ {
handshake();
} }
void Client::die() void Client::die()
@ -23,7 +22,6 @@ void Client::die()
void Client::handshake() void Client::handshake()
{ {
greet();
} }
void Client::dummy() void Client::dummy()

4
Userland/Services/ImageDecoder/ClientConnection.cpp
View file

@ -30,10 +30,6 @@ void ClientConnection::die()
exit(0); exit(0);
} }
void ClientConnection::greet()
{
}
Messages::ImageDecoderServer::DecodeImageResponse ClientConnection::decode_image(Core::AnonymousBuffer const& encoded_buffer) Messages::ImageDecoderServer::DecodeImageResponse ClientConnection::decode_image(Core::AnonymousBuffer const& encoded_buffer)
{ {
if (!encoded_buffer.is_valid()) { if (!encoded_buffer.is_valid()) {

1
Userland/Services/ImageDecoder/ClientConnection.h
View file

@ -26,7 +26,6 @@ public:
virtual void die() override; virtual void die() override;
private: private:
virtual void greet() override;
virtual Messages::ImageDecoderServer::DecodeImageResponse decode_image(Core::AnonymousBuffer const&) override; virtual Messages::ImageDecoderServer::DecodeImageResponse decode_image(Core::AnonymousBuffer const&) override;
}; };

2
Userland/Services/ImageDecoder/ImageDecoderServer.ipc
View file

@ -1,6 +1,4 @@
endpoint ImageDecoderServer endpoint ImageDecoderServer
{ {
greet() => ()
decode_image(Core::AnonymousBuffer data) => (bool is_animated, u32 loop_count, Vector<Gfx::ShareableBitmap> bitmaps, Vector<u32> durations) decode_image(Core::AnonymousBuffer data) => (bool is_animated, u32 loop_count, Vector<Gfx::ShareableBitmap> bitmaps, Vector<u32> durations)
} }