RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 15:47:35 +00:00
Code Issues Activity Actions

LibJS: Ensure make_day()'s temporary Core::DateTime is treated as UTC

Browse source 
DateTime::create() and subsequently DateTime::set_time() uses mktime()
internally to ensure out-of-range input values still result in a valid
date (Jan 32 -> Feb 1 etc.).
This however also means that the input is treated as local time, and
then shifted to UTC accordingly for the returned time_t - it is however
already in UTC in this case! The temporary solution is simply to set the
"TZ" environment variable to "UTC" and back after create(). The proper
solution is probably to have better timezone support in Core::DateTime.
This should only affect Lagom, as serenity itself has no timezone
support yet and always assumes UTC.
This commit is contained in:
Linus Groh 2021-10-30 09:18:01 +02:00
parent 28a9a248d6
commit de2e95b278
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Runtime/Date.cpp
View file

@ -341,7 +341,14 @@ Value make_day(GlobalObject& global_object, Value year, Value month, Value date)
// 8. Find a finite time value t such that YearFromTime(t) is ym and MonthFromTime(t) is mn and DateFromTime(t) is 1𝔽; but if this is not possible (because some argument is out of range), return NaN.
if (!AK::is_within_range<int>(y) || !AK::is_within_range<int>(m + 1))
return js_nan();
// FIXME: Core::DateTime assumes the argument values are in local time, which is not the case here.
// Let mktime() think local time is UTC by temporarily overwriting the TZ environment variable,
// so that the values are not adjusted. Core::DateTime should probably learn to deal with both
// local time and UTC time itself.
auto* tz = getenv("TZ");
VERIFY(setenv("TZ", "UTC", 1) == 0);
auto t = Core::DateTime::create(static_cast<int>(y), static_cast<int>(m + 1), 1).timestamp() * 1000;
tz ? setenv("TZ", tz, 1) : unsetenv("TZ");
// 9. Return Day(t) + dt - 1𝔽.
return Value(day(static_cast<double>(t)) + dt - 1);
}