RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:37:43 +00:00
Code Issues Activity Actions

LibProtocol: Overload Request::stream_into() to accept a Core::Stream

Browse source 
The code is actually identical to the other stream_into() function.
This commit is contained in:
Sam Atkins 2022-01-20 11:46:00 +00:00 • committed by Andreas Kling
parent 20b4bfc892
commit de3225a28b
2 changed files with 36 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Userland/Libraries/LibProtocol/Request.cpp
View file

@ -54,6 +54,40 @@ void Request::stream_into(OutputStream& stream)
};
}
void Request::stream_into(Core::Stream::Stream& stream)
{
VERIFY(!m_internal_stream_data);
auto notifier = Core::Notifier::construct(fd(), Core::Notifier::Read);
m_internal_stream_data = make<InternalStreamData>(fd());
m_internal_stream_data->read_notifier = notifier;
auto user_on_finish = move(on_finish);
on_finish = [this](auto success, auto total_size) {
m_internal_stream_data->success = success;
m_internal_stream_data->total_size = total_size;
m_internal_stream_data->request_done = true;
};
notifier->on_ready_to_read = [this, &stream, user_on_finish = move(user_on_finish)] {
constexpr size_t buffer_size = 4096;
static char buf[buffer_size];
auto nread = m_internal_stream_data->read_stream.read({ buf, buffer_size });
if (!stream.write_or_error({ buf, nread })) {
// FIXME: What do we do here?
TODO();
}
if (m_internal_stream_data->read_stream.eof() && m_internal_stream_data->request_done) {
m_internal_stream_data->read_notifier->close();
user_on_finish(m_internal_stream_data->success, m_internal_stream_data->total_size);
} else {
m_internal_stream_data->read_stream.handle_any_error();
}
};
}
void Request::set_should_buffer_all_input(bool value)
{
if (m_should_buffer_all_input == value)

2
Userland/Libraries/LibProtocol/Request.h
View file

@ -15,6 +15,7 @@
#include <AK/String.h>
#include <AK/WeakPtr.h>
#include <LibCore/Notifier.h>
#include <LibCore/Stream.h>
#include <LibIPC/Forward.h>
namespace Protocol {
@ -38,6 +39,7 @@ public:
bool stop();
void stream_into(OutputStream&);
void stream_into(Core::Stream::Stream&);
bool should_buffer_all_input() const { return m_should_buffer_all_input; }
/// Note: Will override `on_finish', and `on_headers_received', and expects `on_buffered_request_finish' to be set!