RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 17:58:12 +00:00
Code Issues Activity Actions

AK+Everywhere: Consolidate String::index_of() and String::find()

Browse source 
We had two functions for doing mostly the same thing. Combine both
of them into String::find() and use that everywhere.

Also add some tests to cover basic behavior.
This commit is contained in:
Andreas Kling 2021-05-24 11:50:46 +02:00
parent 875a2cbb71
commit de395a3df2
12 changed files with 36 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/UserspaceEmulator/Emulator.cpp
View file

@ -278,7 +278,7 @@ String Emulator::create_backtrace_line(FlatPtr address)
const auto* region = find_text_region(address);
if (!region)
return minimal;
auto separator_index = region->name().index_of(":");
auto separator_index = region->name().find(':');
if (!separator_index.has_value())
return minimal;