RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 01:58:12 +00:00
Code Issues Activity Actions

LibJS: Add conditional expression bytecode generation

Browse source 
Or, by its more common name, the ternary operator :^)
This commit is contained in:
Luke 2021-06-08 04:54:34 +01:00 • committed by Linus Groh
parent 6da587b59b
commit de3ee701ce
2 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/AST.h
View file

@ -1176,6 +1176,7 @@ public:
virtual void dump(int indent) const override; virtual void dump(int indent) const override;
virtual Value execute(Interpreter&, GlobalObject&) const override; virtual Value execute(Interpreter&, GlobalObject&) const override;
virtual Optional<Bytecode::Register> generate_bytecode(Bytecode::Generator&) const override;
private: private:
NonnullRefPtr<Expression> m_test; NonnullRefPtr<Expression> m_test;

19
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -430,4 +430,23 @@ Optional<Bytecode::Register> DebuggerStatement::generate_bytecode(Bytecode::Gene
return {}; return {};
} }
Optional<Bytecode::Register> ConditionalExpression::generate_bytecode(Bytecode::Generator& generator) const
{
auto result_reg = generator.allocate_register();
auto test_reg = m_test->generate_bytecode(generator);
auto& alternate_jump = generator.emit<Bytecode::Op::JumpIfFalse>(*test_reg);
auto consequent_reg = m_consequent->generate_bytecode(generator);
generator.emit<Bytecode::Op::LoadRegister>(result_reg, *consequent_reg);
auto& end_jump = generator.emit<Bytecode::Op::Jump>();
alternate_jump.set_target(generator.make_label());
auto alternative_reg = m_alternate->generate_bytecode(generator);
generator.emit<Bytecode::Op::LoadRegister>(result_reg, *alternative_reg);
end_jump.set_target(generator.make_label());
return result_reg;
}
} }