RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:57:34 +00:00
Code Issues Activity Actions

LibWeb: Make HTMLElement.offset{Left,Top} work on inline elements

Browse source 
Before this change, we were returning (0, 0) for inline elements, due to
a bogus paintable type check in box_type_agnostic_position().
This commit is contained in:
Andreas Kling 2023-08-15 15:51:54 +02:00
parent 79db9c27c6
commit dea91afba7
3 changed files with 86 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/LibWeb/Layout/input/block-and-inline/relpos-inline-element-js-offsets.html Normal file
View file

@ -0,0 +1,20 @@
<style>
b, i {
position: relative;
top: 25px;
}
</style><span>well <b>hello <i>friends</i></b></span>
<div><br><br><br><br><pre id=out></pre></div>
<script>
function println(s) {
let out = document.getElementById("out");
out.innerHTML += s + "\n";
}
let i = document.getElementsByTagName("i")[0]
let b = document.getElementsByTagName("b")[0]
let span = document.getElementsByTagName("span")[0]
println("well: " + span.offsetLeft + ", " + span.offsetTop)
println("hello: " + b.offsetLeft + ", " + b.offsetTop)
println("friends: " + i.offsetLeft + ", " + i.offsetTop)
</script>