RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:27:34 +00:00
Code Issues Activity Actions

LibArchive: Default initialize member variables

Browse source 
Problem:
- `memset` is used to initialize data instead of using default
  initialization.

Solution:
- Default initialize all member variables.
- Eliminate use of `memset` in favor of C++ braced initialization.
This commit is contained in:
Lenny Maiorani 2022-02-15 10:16:31 -07:00 • committed by Idan Horowitz
parent 847efd8aca
commit deba345ca7
2 changed files with 18 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibArchive/TarStream.cpp
View file

@ -131,8 +131,7 @@ TarOutputStream::TarOutputStream(OutputStream& stream)
void TarOutputStream::add_directory(const String& path, mode_t mode)
{
VERIFY(!m_finished);
TarFileHeader header;
memset(&header, 0, sizeof(header));
TarFileHeader header {};
header.set_size(0);
header.set_filename(String::formatted("{}/", path)); // Old tar implementations assume directory names end with a /
header.set_type_flag(TarFileType::Directory);
@ -148,8 +147,7 @@ void TarOutputStream::add_directory(const String& path, mode_t mode)
void TarOutputStream::add_file(const String& path, mode_t mode, ReadonlyBytes bytes)
{
VERIFY(!m_finished);
TarFileHeader header;
memset(&header, 0, sizeof(header));
TarFileHeader header {};
header.set_size(bytes.size());
header.set_filename(path);
header.set_type_flag(TarFileType::NormalFile);