RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 19:05:08 +00:00
Code Issues Activity Actions

Kernel: Ignore zero-length PROGBITS sections in sys$module_load()

Browse source
This commit is contained in:
Andreas Kling 2020-04-10 16:35:40 +02:00
parent 0fea525373
commit dec352dacd
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Process.cpp
View file

@ -4387,6 +4387,8 @@ int Process::sys$module_load(const char* user_path, size_t path_length)
auto module = make<Module>(); auto module = make<Module>();
elf_image->for_each_section_of_type(SHT_PROGBITS, [&](const ELFImage::Section& section) { elf_image->for_each_section_of_type(SHT_PROGBITS, [&](const ELFImage::Section& section) {
if (!section.size())
return IterationDecision::Continue;
auto section_storage = KBuffer::copy(section.raw_data(), section.size(), Region::Access::Read | Region::Access::Write | Region::Access::Execute); auto section_storage = KBuffer::copy(section.raw_data(), section.size(), Region::Access::Read | Region::Access::Write | Region::Access::Execute);
section_storage_by_name.set(section.name(), section_storage.data()); section_storage_by_name.set(section.name(), section_storage.data());
module->sections.append(move(section_storage)); module->sections.append(move(section_storage));
@ -4396,6 +4398,8 @@ int Process::sys$module_load(const char* user_path, size_t path_length)
bool missing_symbols = false; bool missing_symbols = false;
elf_image->for_each_section_of_type(SHT_PROGBITS, [&](const ELFImage::Section& section) { elf_image->for_each_section_of_type(SHT_PROGBITS, [&](const ELFImage::Section& section) {
if (!section.size())
return IterationDecision::Continue;
auto* section_storage = section_storage_by_name.get(section.name()).value_or(nullptr); auto* section_storage = section_storage_by_name.get(section.name()).value_or(nullptr);
ASSERT(section_storage); ASSERT(section_storage);
section.relocations().for_each_relocation([&](const ELFImage::Relocation& relocation) { section.relocations().for_each_relocation([&](const ELFImage::Relocation& relocation) {