RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

LibVideo/VP9: Clamp motion vectors again in find_mv_refs function

Browse source 
The clamping was previously removed apparently, which was unintended
and caused some files to fail to decode properly.
This commit is contained in:
Zaggy1024 2023-01-30 16:58:27 -06:00 • committed by Linus Groh
parent c18728989e
commit df313c3dc5
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibVideo/VP9/Parser.cpp
View file

@ -1582,6 +1582,10 @@ static MotionVector clamp_motion_vector(BlockContext const& block_context, Motio
// find_mv_refs( refFrame, block ) in the spec. // find_mv_refs( refFrame, block ) in the spec.
MotionVectorPair Parser::find_reference_motion_vectors(BlockContext& block_context, ReferenceFrameType reference_frame, i32 block) MotionVectorPair Parser::find_reference_motion_vectors(BlockContext& block_context, ReferenceFrameType reference_frame, i32 block)
{ {
// FIXME: We should be able to change behavior based on the reference motion vector that will be selected.
// If block_context.y_prediction_mode() != NearMv, then we only need the first motion vector that is added to our result.
// This behavior should combine this function with select_best_reference_motion_vectors(). When that is done, check whether
// the motion vector clamping in that function is always a larger area than in this function. If so, we can drop that call.
bool different_ref_found = false; bool different_ref_found = false;
u8 context_counter = 0; u8 context_counter = 0;
@ -1646,6 +1650,8 @@ MotionVectorPair Parser::find_reference_motion_vectors(BlockContext& block_conte
MotionVectorPair result; MotionVectorPair result;
for (auto i = 0u; i < list.size(); i++) for (auto i = 0u; i < list.size(); i++)
result[static_cast<ReferenceIndex>(i)] = list[i]; result[static_cast<ReferenceIndex>(i)] = list[i];
result.primary = clamp_motion_vector(block_context, result.primary, MV_BORDER);
result.secondary = clamp_motion_vector(block_context, result.secondary, MV_BORDER);
return result; return result;
} }